Trending tokens / network switcher cleanup #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
Dec 23, 2024
| const chainId = useTrendingTokensStore(state => state.chainId); | ||
| const selected = useSharedValue<ChainId | undefined>(chainId); |
derHowie
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
lgtm
here's a video of me trying to break networks and sorting: https://www.loom.com/share/7019d35bd0914b57893163a828713ed1 (i didn't)
derHowie
force-pushed
the
@christian/trending-tokens-fixes
branch
from
9ccc6aa to
8416020
Compare
BrodyHughes
added
the
release
BrodyHughes
pushed a commit
that referenced
this pull request
Dec 23, 2024
(cherry picked from commit 5e92d8e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
alignItems: 'baseline'in trending tokens coin rowsScreen recordings / screenshots
What to test